Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Add pigment-css-vite-ts starter example #41196

Merged
merged 10 commits into from
Mar 8, 2024
Merged

[examples] Add pigment-css-vite-ts starter example #41196

merged 10 commits into from
Mar 8, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 20, 2024 •
edited
Loading

image

@siriwatknp siriwatknp added examples Relating to /examples package: pigment-css Specific to @pigment-css/* labels Feb 20, 2024
@mui-bot
Copy link

mui-bot commented Feb 20, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41196--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 09cda44

@siriwatknp siriwatknp changed the title [examples] Add zero-vite starter example [examples] Add zero-vite starter example Feb 26, 2024
@siriwatknp siriwatknp marked this pull request as ready for review February 26, 2024 04:49
danilo-leal
danilo-leal reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick writing review!

examples/zero-vite/index.html Outdated Show resolved Hide resolved
examples/zero-vite/index.html Outdated Show resolved Hide resolved
examples/zero-vite/src/App.tsx Outdated Show resolved Hide resolved
mnajdova
mnajdova reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace the zero with pigment-css?

@siriwatknp siriwatknp changed the title [examples] Add zero-vite starter example [examples] Add pigmentcss-vite-ts starter example Mar 4, 2024
brijeshb42
brijeshb42 reviewed Mar 4, 2024
View reviewed changes
examples/pigmentcss-vite-ts/package.json Outdated
"react-dom": "latest"
},
"devDependencies": {
"@pigmentcss/vite-plugin": "latest",
Copy link
Contributor

@brijeshb42 brijeshb42 Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

brijeshb42
brijeshb42 reviewed Mar 4, 2024
View reviewed changes
examples/pigmentcss-vite-ts/package.json Outdated
"preview": "vite preview"
},
"dependencies": {
"@pigmentcss/react": "latest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have renamed the package, again :)

@siriwatknp siriwatknp changed the title [examples] Add pigmentcss-vite-ts starter example [examples] Add pigment-css-vite-ts starter example Mar 4, 2024
@siriwatknp
Copy link
Member Author

Tested. It works.

curl https://codeload.github.com/siriwatknp/material-ui/tar.gz/zero-vite-starter | tar -xz --strip=2  material-ui-zero-vite-starter/examples/pigment-css-vite-ts      
cd pigment-css-vite-ts

brijeshb42
brijeshb42 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢

@siriwatknp siriwatknp enabled auto-merge (squash) March 8, 2024 06:34
@siriwatknp siriwatknp merged commit 62b6ad3 into mui:master Mar 8, 2024
21 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@siriwatknp @mnajdova
[examples] Add pigment-css-vite-ts starter example (mui#41196)
39a0a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42 brijeshb42 approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
examples Relating to /examples package: pigment-css Specific to @pigment-css/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siriwatknp @mui-bot @brijeshb42 @mnajdova @danilo-leal